Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow custom cache version option for analysis #1244

Merged
merged 221 commits into from Sep 13, 2023
Merged

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Sep 7, 2023

This PR:

Changed:

  • Add cache version option to config case

Review and tests:

  • Tests pass
    • balsamic config case --cache-version Screenshot 2023-09-08 at 16 28 28
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team as a code owner September 7, 2023 13:17
@codecov
Copy link

codecov bot commented Sep 8, 2023

Base automatically changed from cache-version-analysis to develop September 12, 2023 07:39
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for most use-cases this doesn't change anything as the cache-version is by default the current balsamic version. But this allows us, in combination with the changes to the init to build a cache with the release-version we intend to use, and then despite not having bumped the version we can choose the later version for the validation. 🤔 sounds really good! I also found no issues with the code except one very very serious one...(just kidding)
Super nice job! 🌟 🧙 🌟

BALSAMIC/snakemake_rules/align/sentieon_alignment.rule Outdated Show resolved Hide resolved
Co-authored-by: Mathias Johansson <math.joh.bio@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivadym ivadym merged commit 36b9c7d into develop Sep 13, 2023
9 checks passed
@ivadym ivadym deleted the run-cache-version branch September 13, 2023 07:02
@ivadym ivadym mentioned this pull request Sep 13, 2023
6 tasks
@ivadym ivadym linked an issue Sep 13, 2023 that may be closed by this pull request
6 tasks
@ivadym ivadym self-assigned this Sep 22, 2023
@ivadym ivadym mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

Optimise build of cache
2 participants