refactor: Update reference.json to use relative paths #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
6 tasks
mathiasbio
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Amazing job, so clean. This will also make it easier to run tests on feature-branches where you want to copy over an existing cache and make some changes, now you don't need to modify the reference.json anymore! Just point to the new path. Sweet! : )
⭐ 🌟 ⭐ 🌔 ⭐ ⭐ ⭐
🌲 🌲 🌲 🌲 🌲 🌲 🌲
🦖 🦖 🦖 🦖 🦖 🦖 🚒
Co-authored-by: Mathias Johansson <math.joh.bio@gmail.com>
Co-authored-by: Mathias Johansson <math.joh.bio@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
In order to be able to copy the balsamic cache from stage to production, we need to start saving the cache reference file links as relative paths (
reference.json).To maintain simplicity, the
config.jsonreference file will continue to point to stage files, as the cache will be built primarily in the stage from this point onward.Changed:
reference.jsonfile to use relative pathsReview and tests:
Tests pass
balsamic init. Saves relative paths.balsamic config case. Reads relative paths, but saves them as absolute.Code review
New code is executed and covered by tests, and test approve