Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CNVpytor container (fix numpy version to 1.23.5) #1273

Merged
merged 3 commits into from Oct 4, 2023
Merged

fix: CNVpytor container (fix numpy version to 1.23.5) #1273

merged 3 commits into from Oct 4, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Oct 2, 2023 •
edited

This PR:

#1269

Review and tests:

  • Tests pass Screenshot 2023-10-02 at 13 59 18
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team as a code owner October 2, 2023 11:28
@ivadym ivadym linked an issue Oct 2, 2023 that may be closed by this pull request
Develop branch: Error in rule cnvpytor_tumor_only #1269
Closed
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
BALSAMIC/commands/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/case.py 100.00% <100.00%> (+3.44%) ⬆️
BALSAMIC/commands/config/pon.py 100.00% <100.00%> (+4.87%) ⬆️
BALSAMIC/commands/init/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/options.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/status.py 100.00% <100.00%> (ø)
BALSAMIC/commands/run/analysis.py 100.00% <100.00%> (ø)
... and 18 more

📢 Thoughts on this report? Let us know!.

@ivadym ivadym changed the title fix: CNVpytor container (fix numpy version to < 1.24) fix: CNVpytor container (fix numpy version to 1.23.5) Oct 2, 2023
@ivadym ivadym self-assigned this Oct 2, 2023
mathiasbio
mathiasbio approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🔥 🥇 🔥

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivadym ivadym merged commit aee9c89 into develop Oct 4, 2023
23 of 25 checks passed
@ivadym ivadym deleted the fix-cnvpytor-container branch October 4, 2023 07:36
@ivadym ivadym mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbio mathiasbio mathiasbio approved these changes

@khurrammaqbool khurrammaqbool Awaiting requested review from khurrammaqbool

Assignees

@ivadym ivadym

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop branch: Error in rule cnvpytor_tumor_only
2 participants
@ivadym @mathiasbio