Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate cache models to pydantic v2 #1274

Merged
merged 7 commits into from Oct 4, 2023
Merged

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Oct 2, 2023

This PR:

Changed:

  • Migrate cache models to pydantic v2

Review and tests:

  • Tests pass

    • Cache build successfully
    Screenshot 2023-10-04 at 14 54 01
  • Code review

  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team as a code owner October 2, 2023 14:17
@ivadym ivadym self-assigned this Oct 2, 2023
@ivadym ivadym linked an issue Oct 2, 2023 that may be closed by this pull request
5 tasks
@ivadym ivadym mentioned this pull request Sep 29, 2023
5 tasks
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
BALSAMIC/commands/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/case.py 100.00% <100.00%> (+3.44%) ⬆️
BALSAMIC/commands/config/pon.py 100.00% <100.00%> (+4.87%) ⬆️
BALSAMIC/commands/init/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/options.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/status.py 100.00% <100.00%> (ø)
BALSAMIC/commands/run/analysis.py 100.00% <100.00%> (ø)
... and 18 more

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@khurrammaqbool khurrammaqbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Could you please also fix the deprecation warning, pasted below, that may be relevant here.

../../../../../usr/share/miniconda/envs/balsamic/lib/python3.11/site-packages/pydantic_core/core_schema.py:3921
  /usr/share/miniconda/envs/balsamic/lib/python3.11/site-packages/pydantic_core/core_schema.py:3921: DeprecationWarning: `FieldValidationInfo` is deprecated, use `ValidationInfo` instead.
    warnings.warn(msg, DeprecationWarning, stacklevel=1)

The rest of the warnings are relevant for PDF report, which may need attention as well, which may be taken up in separate PR.

@ivadym
Copy link
Contributor Author

ivadym commented Oct 4, 2023

👍 Looks good. Could you please also fix the deprecation warning, pasted below, that may be relevant here.

../../../../../usr/share/miniconda/envs/balsamic/lib/python3.11/site-packages/pydantic_core/core_schema.py:3921
  /usr/share/miniconda/envs/balsamic/lib/python3.11/site-packages/pydantic_core/core_schema.py:3921: DeprecationWarning: `FieldValidationInfo` is deprecated, use `ValidationInfo` instead.
    warnings.warn(msg, DeprecationWarning, stacklevel=1)

The rest of the warnings are relevant for PDF report, which may need attention as well, which may be taken up in separate PR.

Good catch! It became deprecated in the time from my first PR regarding pydantic 😆

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivadym ivadym merged commit f020e62 into develop Oct 4, 2023
7 checks passed
@ivadym ivadym deleted the migrate-cache-models branch October 4, 2023 14:38
@ivadym ivadym mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

Migrating from Pydantic v1 to v2
2 participants