Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove archived/outdated workflows and scripts #1296

Merged
merged 2 commits into from Oct 25, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Oct 24, 2023

This PR:

Having dead code in the project that keeps popping out when I do global searches is annoying. I'm removing it.

Removed:

  • Archived/outdated workflows and scripts

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team as a code owner October 24, 2023 12:50
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ivadym ivadym self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
BALSAMIC/commands/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/case.py 100.00% <100.00%> (+3.44%) ⬆️
BALSAMIC/commands/config/pon.py 100.00% <100.00%> (+4.87%) ⬆️
BALSAMIC/commands/init/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/options.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/status.py 100.00% <100.00%> (ø)
BALSAMIC/commands/run/analysis.py 100.00% <100.00%> (ø)
... and 18 more

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those scripts look like they could be useful, or have been useful at some point. But we can dig them out of the grave in the future (💀 🧙 💚 ) if we realise we need to make coverage-plots from sambamba, or plot mutational signatures, or want to...I don't know exactly what VariantReport was used for...filtering variants and calculating TMB? 🔥

@ivadym ivadym merged commit 5cbb9dc into develop Oct 25, 2023
9 checks passed
@ivadym ivadym deleted the remove-archived-workflows branch October 25, 2023 07:22
@ivadym ivadym mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

None yet

2 participants