Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MultiQC rule input files #1321

Merged
merged 6 commits into from Nov 8, 2023
Merged

fix: MultiQC rule input files #1321

merged 6 commits into from Nov 8, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Nov 7, 2023

This PR:

Bug affecting the UMI workflow, as we forgot to add a file extension to some Picard output files:

Screenshot 2023-11-07 at 13 44 31

We should've spotted it in our pytests, but we don't have a DAG graph test for the UMI workflow 😞

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym added the Bug Something isn't working label Nov 7, 2023
@ivadym ivadym self-assigned this Nov 7, 2023
@ivadym ivadym requested a review from a team as a code owner November 7, 2023 12:51
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! ⭐ Thank you! ❤️

@ivadym ivadym merged commit 33f1531 into release_v13.0.0 Nov 8, 2023
8 checks passed
@ivadym ivadym deleted the fix-multiqc-umi branch November 8, 2023 09:16
@ivadym ivadym mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants