Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper pair eval #2053

Merged
merged 5 commits into from Oct 5, 2023
Merged

Improper pair eval #2053

merged 5 commits into from Oct 5, 2023

Conversation

jemten
Copy link
Collaborator

@jemten jemten commented Oct 4, 2023

This PR adds | fixes:

How to test:

  • Automatic and continuous test suite

Expected outcome:

  • Installation, unit and integration test suite pass

Review:

  • Code review
  • Tests pass

This version is a:

  • MAJOR - when you make incompatible API changes. If applicable record manual test results in PR header
  • MINOR - when you add functionality in a backwards compatible manner. If applicable record manual test results in PR header
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@jemten jemten requested review from henrikstranneheim and a team as code owners October 4, 2023 15:38
peterpru
peterpru approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@peterpru peterpru left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

t/parse_limit_qc_output.t Outdated Show resolved Hide resolved
@jemten @peterpru
Update t/parse_limit_qc_output.t
e67528c 
Co-authored-by: Peter Pruisscher <57712924+peterpru@users.noreply.github.com>
@jemten jemten merged commit d12e13a into develop Oct 5, 2023
9 checks passed
@jemten jemten deleted the improper_pair_eval branch October 5, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpru peterpru peterpru approved these changes

@henrikstranneheim henrikstranneheim Awaiting requested review from henrikstranneheim henrikstranneheim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jemten @peterpru