Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(rna_cleanup): remove cp to temp dir #780

Merged
merged 2 commits into from Apr 1, 2019

Conversation

jemten
Copy link
Collaborator

@jemten jemten commented Mar 31, 2019

  • removed cp to temp dir for rna recipes
  • made assembly of RNA transcripts more stringent

@jemten
Copy link
Collaborator Author

jemten commented Mar 31, 2019

@henrikstranneheim,
Coverage drops since the subs migrate_files and xargs_migrate_contig_files aren't used anymore. We should either remove them or write tests for them. I can write some tests and attach them to this PR if we want to keep them around. What do you think?

@henrikstranneheim
Copy link
Collaborator

Actually, let's remove them. I think it is better so start from scratch when (if) the situation arises that we need the functionality again so that is it tailored towards solving that need and not a historical need. Furthermore, dead code has a way of becoming unusable after a while anyway.

@jemten jemten merged commit 55af479 into Clinical-Genomics:develop Apr 1, 2019
@jemten jemten deleted the feature/rna_recipe_cleanup branch April 1, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants