fix review

Clinical-Genomics · Dec 5, 2023 · 726a162 · 726a162
1 parent 2b8ac38
commit 726a162
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/arnold/crud/read/sample.py b/arnold/crud/read/sample.py
@@ -12,10 +12,10 @@ def find_sample(adapter: ArnoldAdapter, sample_id: str) -> Optional[Sample]:
     raw_sample = adapter.sample_collection.find_one({"_id": sample_id})
     if not raw_sample:
         return None
-    return Sample(**raw_sample)
+    return Sample.model_validate(raw_sample)
 
 
 def find_all_samples(adapter: ArnoldAdapter) -> List[Sample]:
     """Find all samples from the step collection"""
     raw_samples = adapter.sample_collection.find()
-    return [Sample(**raw_sample) for raw_sample in raw_samples]
+    return [Sample.model_validate(raw_sample) for raw_sample in raw_samples]
diff --git a/arnold/models/database/sample.py b/arnold/models/database/sample.py
@@ -7,7 +7,7 @@ class Sample(BaseModel):
     """LIMS Sample Collection"""
 
     sample_id: str
-    id: Optional[str] = Field(..., alias="_id", serialization_alias='_id')
+    id: Optional[str] = Field(..., alias="_id")
     ticket: Optional[str] = None
     received_date: Optional[datetime] = None
     delivery_date: Optional[datetime] = None