Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean tests and constants from bcl2fastq #3174

Merged
merged 35 commits into from Apr 25, 2024
Merged

Clean tests and constants from bcl2fastq #3174

merged 35 commits into from Apr 25, 2024

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Apr 23, 2024

Description

Remove unused constants, fixtures and tests related to bcl2fastq.

Review

  • "Merge and deploy" approved by SA
    Thanks for filling in who performed the code review and the test!

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Deployed to stage:
  • Deployed to production:

@diitaz93 diitaz93 self-assigned this Apr 23, 2024
@diitaz93 diitaz93 added Project Task Part of a quarterly project demultiplex labels Apr 23, 2024
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@diitaz93 diitaz93 marked this pull request as ready for review April 24, 2024 15:24
@diitaz93 diitaz93 requested a review from a team as a code owner April 24, 2024 15:24
Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup 🧹

@diitaz93 diitaz93 merged commit fee63f4 into master Apr 25, 2024
9 checks passed
@diitaz93 diitaz93 deleted the remove-bcl2fastq-10 branch April 25, 2024 07:10
@diitaz93
Copy link
Contributor Author

Deployment pending due to hasta being slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demultiplex Project Task Part of a quarterly project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants