Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary arguments #3230

Merged
merged 1 commit into from
May 15, 2024
Merged

Remove unnecessary arguments #3230

merged 1 commit into from
May 15, 2024

Conversation

sofstam
Copy link
Contributor

@sofstam sofstam commented May 15, 2024

Description

Fixed

  • Remove unnecessary arguments when running taxprofiler

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b patch_arguments_tax -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@sofstam sofstam requested a review from a team as a code owner May 15, 2024 08:28
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sofstam sofstam merged commit 34febea into master May 15, 2024
9 checks passed
@sofstam sofstam deleted the patch_arguments_tax branch May 15, 2024 08:33
@sofstam
Copy link
Contributor Author

sofstam commented May 15, 2024

Deploy stage:
Screenshot 2024-05-15 at 10 38 53

@sofstam
Copy link
Contributor Author

sofstam commented May 15, 2024

Deploy production:

Screenshot 2024-05-15 at 10 44 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants