Remove "-d" short flag from "delivery-type" and "days-ago" options #3238
Conversation
|
The following documentation will need to be changed as well in Atlas:
|
|
I spoke with @Karl-Svard and production would prefer removing the |
|
Ok, sounds good! Usability is key here I think. |
|
Removing the -d flag would also mean to change the tests in place. |
Since we'll be deprecating the data delivery flag, I would say we remove the |
|
| class PacbioConfig(BaseModel): | ||
| data_dir: str | ||
| systemd_trigger_dir: str | ||
|
|
||
|
|
||
| class OxfordNanoporeConfig(BaseModel): | ||
| data_dir: str | ||
| systemd_trigger_dir: str | ||
|
|
||
|
|
||
| class IlluminaConfig(BaseModel): | ||
| flow_cell_runs_dir: str | ||
| demultiplexed_runs_dir: str | ||
|
|
||
|
|
||
| class RunInstruments(BaseModel): | ||
| pacbio: PacbioConfig | ||
| nanopore: OxfordNanoporeConfig | ||
| illumina: IlluminaConfig | ||
|
|
||
|
|
There was a problem hiding this comment.
I think you need to check your branch. This undoes some changes introduced with other prs
There was a problem hiding this comment.
Yes I had a problem with git, I created another branch (Remove dryrun flag #3244) to replace this one.
There was a problem hiding this comment.
Feel free to close this one to avoid confusion :)
|
Closing, replaced by #3244 |
Description
Fixing issue #3234
Remove "-d" short flag from "delivery-type" and "days-ago" option to avoid conflict with "-d" from dry-run option.
Changed
/Users/eliottbosshard/cg/cg/cli/deliver/base.pyand "days-ago" option in/Users/eliottbosshard/cg/cg/cli/upload/mutacc.pyHow to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan