-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add IlluminaFlowCellDevice model #3239
Conversation
Apparently what we called "flow cell model" (10B, 25B) is officially called "type", which is the field we use for polymorphism. I changed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think short and descriptive names for the fields are better. We already have a clear name for the Model, so we don't need to duplicate the information in the field name
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Closes https://github.com/Clinical-Genomics/add-new-tech/issues/2
Added
How to prepare for test
How to test
alembic -c $ALEMBIC_CG_STAGE upgrade fe23de4ed528
fe23de4ed528
run_device
table of typeILLUMINA
illumina_flow_cell
with the same id as the previous entry and mode10B
.alembic -c $ALEMBIC_CG_STAGE downgrade 6e6c36d5157b
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan
Logging deploy ... Getting deployer... done. Getting last commit message and SHA... done. Getting version of deploy scripts... /home/js.diazboada done. Log deploy... done. cg, version 60.7.25 [js.diazboada@hasta:~] [S_base] $ up