decouple genotype api #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonso
requested review from
barrystokman,
Mropat and
patrikgrenfeldt
as code owners
added 4 commits
September 23, 2020 15:53
Removes two mip run tests because of conda environment problems
…uple-genotype-api
|
Hi @Mropat , this one is ready for review! |
Mropat
reviewed
Sep 28, 2020
Mropat
reviewed
Sep 28, 2020
Mropat
approved these changes
Sep 28, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
|
Merged and deployed on hasta |
|
"code approved by" and ""Merge and deploy" approved by" is missing |
I see this all the time but we should get better on reminding each other. When you did the review @patrikgrenfeldt you did not approve or requested changes. Was there any particular reason for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the genotype package from CG. From now on genotype will live in another conda environment and will be called on from the CLI.
How to prepare for test
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-cg-stage.sh [THIS-BRANCH-NAME]How to test
Expected test outcome
check that the command worked
check that the samples where added
Take a screenshot and attach or copy/paste the output.
Review
Thanks for filling in who performed the code review and the test!
This version is a