Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): updates tags for housekeeper #784

Merged
merged 9 commits into from
Oct 23, 2020
Merged

Conversation

jemten
Copy link
Contributor

@jemten jemten commented Oct 6, 2020

Updates tags for housekeeper relating to chromograph and upd tracks.
Relates to housekeeper/#76

The following tags should be added to housekeeper:

File type Tags
<file-prefix>.regions.bb upd, regions
<file-prefix>.sites.bb upd, sites
<file-prefix>.regions_<contig>.png chromograph, upd, regions
<file-prefix>.sites_<contig>.png chromograph, upd, sites
<file-prefix>_<contig>.png chromograph, tcov
<file-prefix>.<sample>.bw rhocall-viz

How to prepare for test

  • run justhusky with the config changes in servers/pull/#427
  • ssh to hasta (depending on type of change)
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-cg-stage.sh mip_9.0.3

How to test

  • cg workflow mip-dna store analysis
  • housekeeper get file -v <bundle-version>

Expected test outcome

  • check that the files are added together with their respective tags ✅
  • Take a screenshot and attach or copy/paste the output. ✅

Review

  • code approved by HS
  • tests executed by AJ
  • "Merge and deploy" approved by HS
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@jemten
Copy link
Contributor Author

jemten commented Oct 6, 2020

@dnil - With this PR housekeeper should store the big bed file from upd and the big wig file from rhocall viz. Was there a plan to display these tracks in scouts IGV view?

@Mropat
Copy link
Contributor

Mropat commented Oct 11, 2020

👍 Just need to post a validation screenshot to merge!

@dnil
Copy link
Contributor

dnil commented Oct 12, 2020

@dnil - With this PR housekeeper should store the big bed file from upd and the big wig file from rhocall viz. Was there a plan to display these tracks in scouts IGV view?

Nicely done! Yes, absolutely! There are keys for them in Scout; let me know if you want a list for the load config!

@coveralls
Copy link
Collaborator

coveralls commented Oct 12, 2020

Coverage Status

Coverage remained the same at 73.603% when pulling ee82711 on mip_9.0.3 into 73ecc27 on master.

@jemten jemten marked this pull request as ready for review October 23, 2020 08:35
@jemten
Copy link
Contributor Author

jemten commented Oct 23, 2020

cg workflow mip-dna store analysis analysis/justhusky_config.yaml ✔️
image

housekeeper get file -v 24966 justhusky ✔️
image

Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@henrikstranneheim henrikstranneheim merged commit b9ba559 into master Oct 23, 2020
@henrikstranneheim henrikstranneheim deleted the mip_9.0.3 branch October 23, 2020 13:19
@henrikstranneheim
Copy link
Contributor

Deployed on hasta:
Screenshot 2020-10-23 at 15 24 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants