Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions for pytest & coveralls and for building and pushing to Docker Hub #219

Merged
merged 6 commits into from
Nov 12, 2020

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Nov 12, 2020

This PR adds | fixes:

  • Switch to Github actions for tests and coverage
  • Added action to build the Docker image and pushing it to Docker Hub with 2 tags: "latest" and actual latest repo tag.

How to prepare for test:

  • It's all automated but this needs fixing:
  • DOCKER_USERNAME secret
  • DOCKER_PASSWORD secret

How to test:

  • Just watch

Expected outcome:

  • tests should pass

Review:

  • Code approved by
  • Tests executed by Github actions

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@coveralls
Copy link

coveralls commented Nov 12, 2020

Coverage Status

Coverage remained the same at 99.209% when pulling c94d5bb on build_and_dockerhub_push_action into 9bbcb89 on master.

@northwestwitch
Copy link
Member Author

Ready for review. An easy one!

@northwestwitch
Copy link
Member Author

northwestwitch commented Nov 12, 2020

In order to push to Docker Hub I need to create the secrets and I need an admin.. @moonso? 😁

@moonso
Copy link
Contributor

moonso commented Nov 12, 2020

Nice @northwestwitch , I've added them on the organisational level. Not 100% how it works but please test

Copy link
Contributor

@moonso moonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@northwestwitch
Copy link
Member Author

Nice @northwestwitch , I've added them on the organisational level. Not 100% how it works but please test

Cool, thanks!

@northwestwitch northwestwitch merged commit f580123 into master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants