Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom coverage thresholds on report #288

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Apr 18, 2024

This PR adds | fixes:

How to test:

  • Deploy on stage.
  • Uncomment the 'REPORT_COVERAGE_LEVELS' .env parameter
  • Create any report (from scout or also demo report)

Expected outcome:

  • The report should show the metrics for the coverage levels: 100,150,200,300,500

Review:

  • Code approved by HS
  • Tests executed by CR

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch changed the title More coverage thresholds on report Custom coverage thresholds on report Apr 18, 2024
@northwestwitch northwestwitch added Effort S Effort small Enhancement New feature or request labels Apr 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.56%. Comparing base (2cc3fa4) to head (ec1efdd).
Report is 59 commits behind head on main.

Files Patch % Lines
src/chanjo2/models/pydantic_models.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   94.54%   94.56%   +0.02%     
==========================================
  Files          35       35              
  Lines        1943     1987      +44     
==========================================
+ Hits         1837     1879      +42     
- Misses        106      108       +2     
Flag Coverage Δ
unittests 94.56% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch marked this pull request as ready for review April 18, 2024 07:48
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@northwestwitch
Copy link
Member Author

Demo report after uncommenting the .env param: 🆗

image image

Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@northwestwitch northwestwitch merged commit 315adef into main Apr 18, 2024
7 checks passed
@northwestwitch northwestwitch deleted the more_coverage_thresholds_on_report branch April 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort S Effort small Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally adjusting reported coverage limits
3 participants