Add output prefix #113
Merged
Add output prefix #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2020 12:42
… into add_output_prefix Include r-base updates in installation
sylvinite
approved these changes
Oct 14, 2020
|
Results of testing PR: Paths in deliverables files exists and contain sample ID. Exceptions are samples that (as expected) failed the analysis, i.e. NTC and low quality samples. Is missing data handled at a later step as for MIP? |
sylvinite
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The features of this PR primarily concerns internals
Summary of the changes made:
If not self-evident, mention what prompted the change.
Primary function of PR
Testing
If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.
Test routine to verify the stability of the PR:
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-microsalt-stage.sh add_output_prefixussource activate S_microSALTmicroSALT analyse /home/proj/stage/microbial/queries/ACC5551.json --input /home/proj/stage/microbial/fastq/ACC5551microSALT analyse /home/proj/stage/microbial/queries/ACC5551A1.json --input /home/proj/stage/microbial/fastq/ACC5551/ACC5551A1Ensure there are no errors when running the analysisVerify that all files specified in the deliverables file existTest results
Paths in deliverables files exists and contain sample ID.
No unexpected errors
Exceptions are samples that (as expected) failed the analysis, i.e. NTC and low quality samples. Is missing data handled at a later step as for MIP?
Sign-offs