Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in mlst download for some organisms #130

Merged
merged 1 commit into from Feb 4, 2021

Conversation

talnor
Copy link
Contributor

@talnor talnor commented Feb 4, 2021

Description

Some organisms on pubMLST did not have the MLST scheme as the first scheme. MicroSALT downloads therefore exited with HTTP errors and was unable to update the data for some organisms.

The features of this PR primarily concerns end-users/bioinformaticians/internals

Summary of the changes made:

  • Adapted query paths for MLST downloads, considering the variability.

Primary function of PR

  • Hotfix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Sign-offs

  • Code tested by Travis
  • Approved to run at Clinical-Genomics by @sylvinite

@sylvinite sylvinite merged commit 2f0b652 into master Feb 4, 2021
@talnor
Copy link
Contributor Author

talnor commented Feb 8, 2021

This fixes issue #129

@sylvinite sylvinite deleted the fix_pubMLST_downloads branch February 12, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants