Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of --isolate flag, and update of SPAdes assembler #165

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

talnor
Copy link
Contributor

@talnor talnor commented Jan 8, 2024

Description

Summary of the changes made:

  • Changed assembly command to exclude the --careful flag by default.
  • Change assembly command to include the --isolate
  • Updated spades assembler to 3.15.5

Fix for #164.

Primary function of PR

  • Hotfix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Test routine to verify the stability of the PR:

  • us
  • install branch in stage
  • cg workflow microsalt start vocalcoral

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

@talnor talnor requested a review from a team as a code owner January 8, 2024 12:40
@talnor talnor changed the title Noncareful assembly default Noncareful assembly by default Jan 8, 2024
Copy link

@karlnyr karlnyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to set the default to --uncareful which is the behavior we want, neat!

@talnor talnor force-pushed the noncareful_assembly_default branch from 4d63d4a to 40e0bd4 Compare January 29, 2024 10:35
@talnor
Copy link
Contributor Author

talnor commented Feb 7, 2024

Failed samples pass with updating settings. Typing of other samples remain the same.

v.3.3.6

v 3 3 6

v.3.4.0

v 3 4 0

@karlnyr karlnyr changed the title Noncareful assembly by default Use of --isolate flag, and update of SPAdes assembler May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants