Upgrade python version in tests action and remove pytest dependency #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2023 08:29
northwestwitch
changed the title
northwestwitch
changed the title
henrikstranneheim
approved these changes
Dec 8, 2023
pyproject.toml
Outdated
| @@ -22,12 +22,15 @@ importlib-resources = "^5.12.0" | |||
| uvicorn = "^0.21.1" | |||
| pydantic = "^2.5.2" | |||
| pydantic-settings = "^2.1.0" | |||
| pytest = "^7.4.3" | |||
There was a problem hiding this comment.
Suggested change
| pytest = "^7.4.3" |
There was a problem hiding this comment.
It's a good idea, but then I should modify the action, because as it is it installs pytest from the repo dependencies
| @@ -30,7 +30,8 @@ def test_ensembl_exons( | |||
| mocker.patch("schug.endpoints.exons.stream_resource", return_value=exons_lines) | |||
|
|
|||
| # WHEN sending a request to Biomart to retrieve exons in the given build | |||
| response: Response = client.get(f"{endpoints.ENSEMBL_EXONS}?build={build}") | |||
| response: Response = client.get(f"{endpoints.ENSEMBL_EXONS.value}?build={build}") | |||
There was a problem hiding this comment.
With python 3.11 and if you make the
Endpoints(str, Enum)
a StrEnum instead you do not have to coerce using .value
There was a problem hiding this comment.
Will it work also with python 3.8?
There was a problem hiding this comment.
Only with >=3.11 - something for the future then.
|
Kudos, SonarCloud Quality Gate passed!
|
northwestwitch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds | fixes:
How to test:
Review:
This version is a: