New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed variant csv file verification #3060
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
+ Coverage 83.71% 83.76% +0.04%
==========================================
Files 286 286
Lines 16480 16490 +10
==========================================
+ Hits 13797 13813 +16
+ Misses 2683 2677 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out my suggestion!
@@ -124,6 +124,36 @@ The out put files of expansion hunter if preferably annotated with [stranger][st | |||
### Compounds (top 20) | |||
Only interesting when the compound inheritance pattern is required, the list can be very long but is by default cropped to the top 20 highest ranked ones as shown in the heading. | |||
|
|||
## Managed variants | |||
|
|||
### Managed variants upload file format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly! 🥇
I have a few suggestions:
- Since we are touching the functionality: improving the looks of this form by placing all elements on one line, with the right spacing and vertical padding.
tests/server/blueprints/managed_variants/test_managed_variants_controllers.py
Show resolved
Hide resolved
Thank you for the review! |
Co-authored-by: Chiara Rasi <rasi.chiara@gmail.com>
…al-Genomics/scout into fix_managed_variant_verif
Ok, it was just a small thing, broken with an earlier update.. |
This PR adds a functionality and updates documentation.
How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: