Skip to content

Commit

Permalink
Merge branch 'master' into refactor_get_latest_analysis
Browse files Browse the repository at this point in the history
# Conflicts:
#	tests/store/test_store_api.py
#	trailblazer/store/api.py
  • Loading branch information
henrikstranneheim committed Aug 28, 2023
2 parents b9cdb9c + b00f857 commit b8aff88
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 17.0.3
current_version = 17.0.4
commit = True
tag = True
tag_name = {new_version}
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def parse_reqs(req_path="./requirements.txt"):

setup(
name=NAME,
version="17.0.3",
version="17.0.4",
description=DESCRIPTION,
long_description=LONG_DESCRIPTION,
long_description_content_type="text/markdown",
Expand Down
25 changes: 0 additions & 25 deletions tests/store/test_store_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,31 +76,6 @@ def test_add_comment(analysis_store: MockStore, case_name: str):
assert analysis.comment == comment


@pytest.mark.parametrize(
"case_name, expected_status",
[
("blazinginsect", TrailblazerStatus.RUNNING),
("nicemice", TrailblazerStatus.COMPLETED),
("lateraligator", TrailblazerStatus.FAILED),
("escapedgoat", TrailblazerStatus.PENDING),
],
)
def test_get_latest_analysis_status(
analysis_store: MockStore, case_name: str, expected_status: str
):
"""Test getting the status for the latest case analysis."""
# GIVEN an analysis
analysis_store.update_ongoing_analyses()
analysis: Optional[Analysis] = analysis_store.get_latest_analysis_for_case(case_name=case_name)
assert analysis is not None

# WHEN getting analysis status for case
status: Optional[str] = analysis_store.get_latest_analysis_status(case_id=case_name)

# THEN it should return the expected result
assert status == expected_status


@pytest.mark.parametrize(
"case_name, status",
[
Expand Down
6 changes: 0 additions & 6 deletions trailblazer/store/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,6 @@ def analyses(

return analysis_query.order_by(self.Analysis.started_at.desc())

def get_latest_analysis_status(self, case_id: str) -> Optional[str]:
"""Get the latest analysis status for a case name."""
latest_analysis = self.get_latest_analysis_for_case(case_name=case_id)
if latest_analysis:
return latest_analysis.status

def mark_analyses_deleted(self, case_id: str) -> Query:
"""mark analyses connected to a case as deleted"""
old_analyses = self.analyses(case_id=case_id)
Expand Down

0 comments on commit b8aff88

Please sign in to comment.