Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): Remove unused function #265

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Aug 24, 2023

Description

Remove function get_latest_analysis_status as it is not used.

Changed

  • Remove function get_latest_analysis_status as it is not used.

How to prepare for test

  • ssh to hasta (depending on type of change)
  • activate stage: us
  • request trailblazer-stage on hasta: paxa
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b remove_get_latest_analysis_status -a
  • ssh to clinical-db (depending on type of change)
  • install on stage:
    bash /home/proj/production/servers/resources/clinical-db.scilifelab.se/update-trailblazer-ui-stage.sh [THIS-BRANCH-NAME]

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim henrikstranneheim added the Project Task Part of a quarterly project label Aug 24, 2023
@henrikstranneheim henrikstranneheim self-assigned this Aug 24, 2023
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner August 24, 2023 13:57
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it isn't used! 🔥

Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no references to this function in trailblazer 👍

@clingen-sthlm clingen-sthlm temporarily deployed to stage August 28, 2023 14:03 Inactive
@henrikstranneheim
Copy link
Contributor Author

CLI ✅

68° [henrik.stranneheim@hasta:~] [S_base] 2m25s $ trailblazer ls
272007 | richurchin 2023-08-24 [WGS/QC]
272004 | truepigeon 2023-08-22 [WTS/FAILED]
272001 | cuddlyhen 2023-08-17 [WTS/FAILED]
271975 | ampleray 2023-07-25 [WTS/COMPLETED] - None
271971 | acetuna 2023-07-24 [TGS/COMPLETED] - None
271970 | uphippo 2023-07-24 [TGS/FAILED]
271969 | equalbug 2023-07-24 [TGS/FAILED]
271968 | unitedbeagle 2023-07-24 [TGS/COMPLETED] - None
271967 | setamoeba 2023-07-24 [TGS/COMPLETED] - None
271966 | fleetjay 2023-07-24 [WGS/FAILED]
271965 | civilsole 2023-07-24 [WGS/FAILED]
271957 | uphippo_rsync 2023-07-17 [OTHER/FAILED]
271955 | setamoeba_rsync 2023-07-17 [OTHER/FAILED]
271907 | equalbug_rsync 2023-07-07 [OTHER/FAILED]
271906 | equalbug_rsync 2023-07-07 [OTHER/FAILED]
271905 | equalbug_rsync 2023-07-07 [OTHER/FAILED]
271904 | H27CLDRX3 2023-06-30 [OTHER/COMPLETED] - None
271903 | intentcorgi 2023-06-27 [WGS/COMPLETED] - None
271902 | sharpwhale 2023-06-26 [WGS/COMPLETED] - None
271901 | safeguinea 2023-06-26 [WGS/COMPLETED] - None
271900 | onemite 2023-06-26 [WGS/COMPLETED] - None
271899 | brightcaiman 2023-06-26 [WGS/COMPLETED] - None
271897 | tenderoriole 2023-06-22 [TGS/COMPLETED] - None
271896 | strongbison 2023-06-22 [WES/COMPLETED] - None
271894 | sharppigeon 2023-06-22 [WGS/COMPLETED] - None
271892 | proudcougar 2023-06-22 [WGS/COMPLETED] - None
271890 | nextjackal 2023-06-22 [WGS/COMPLETED] - None
271889 | modernmule 2023-06-22 [WGS/COMPLETED] - None
271888 | intentmayfly 2023-06-22 [WGS/COMPLETED] - None
271887 | kindcaiman 2023-06-22 [WGS/COMPLETED] - None

@henrikstranneheim henrikstranneheim merged commit 8b7b580 into master Aug 28, 2023
6 checks passed
@henrikstranneheim henrikstranneheim deleted the remove_get_latest_analysis_status branch August 28, 2023 14:11
@henrikstranneheim
Copy link
Contributor Author

Deployed in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project Task Part of a quarterly project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants