Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor set analysis status #274

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Sep 6, 2023

Description

Refactor set analysis status

Added

  • Tests

Changed

  • Refactor set analysis status and migrate to CRUD

Fixed

How to prepare for test

  • ssh to hasta (depending on type of change)
  • activate stage: us
  • request trailblazer-stage on hasta: paxa
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b refactor_set_analysis_status -a
  • ssh to clinical-db (depending on type of change)
  • install on stage:
    bash /home/proj/production/servers/resources/clinical-db.scilifelab.se/update-trailblazer-ui-stage.sh [THIS-BRANCH-NAME]

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim henrikstranneheim requested a review from a team as a code owner September 6, 2023 11:37
@henrikstranneheim henrikstranneheim changed the title Refacrtor set analysis status Refactor set analysis status Sep 6, 2023
@henrikstranneheim henrikstranneheim self-assigned this Sep 6, 2023
@henrikstranneheim henrikstranneheim added the Project Task Part of a quarterly project label Sep 6, 2023
@clingen-sthlm clingen-sthlm temporarily deployed to stage September 6, 2023 11:43 Inactive
@henrikstranneheim
Copy link
Contributor Author

CLI and API ✅

θ62° [henrik.stranneheim@hasta:~] [S_base] 7s $ trailblazer set-status --status error  justhusky
justhusky - Status set to ERROR
Screenshot 2023-09-06 at 13 51 59
θ60° [henrik.stranneheim@hasta:~] [S_base] 7s 2 $ trailblazer set-completed 278312
justhusky - Status set to COMPLETED
Screenshot 2023-09-06 at 13 55 47

@clingen-sthlm clingen-sthlm temporarily deployed to stage September 6, 2023 13:07 Inactive
# Conflicts:
#	trailblazer/cli/core.py
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

trailblazer/server/api.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@clingen-sthlm clingen-sthlm temporarily deployed to stage September 11, 2023 09:22 Inactive
@henrikstranneheim
Copy link
Contributor Author

Redid the same tests - all pass

@henrikstranneheim henrikstranneheim merged commit eeb207f into master Sep 11, 2023
6 checks passed
@henrikstranneheim henrikstranneheim deleted the refactor_set_analysis_status branch September 11, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project Task Part of a quarterly project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants