Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch update analysis #304

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Patch update analysis #304

merged 6 commits into from
Nov 15, 2023

Conversation

seallard
Copy link
Contributor

Description

Patches a broken endpoint in the web api for updating the analysis from cigrid. Closes #303.

Fixed

  • Patch broken endpoint for updating an analysis

How to test

  • deploy to web stage
  • verify that the status/visibility and comment can be updated.

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@seallard seallard requested a review from a team as a code owner November 14, 2023 13:31
@clingen-sthlm clingen-sthlm temporarily deployed to stage November 14, 2023 13:33 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage November 14, 2023 13:39 Inactive
islean
islean approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

trailblazer/store/crud/update.py Outdated Show resolved Hide resolved
trailblazer/server/api.py Outdated Show resolved Hide resolved
trailblazer/server/api.py Show resolved Hide resolved
diitaz93
diitaz93 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@clingen-sthlm clingen-sthlm temporarily deployed to stage November 14, 2023 14:32 Inactive
henrikstranneheim
henrikstranneheim approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clingen-sthlm clingen-sthlm temporarily deployed to stage November 15, 2023 12:04 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage November 15, 2023 12:11 Inactive
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@clingen-sthlm clingen-sthlm temporarily deployed to stage November 15, 2023 12:37 Inactive
@seallard
Copy link
Contributor Author

Tested in stage, fields can be edited as expected

@seallard seallard merged commit b1e7e3d into master Nov 15, 2023
6 checks passed
@seallard seallard deleted the patch-analysis-endpoint branch November 15, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrOertlin ChrOertlin ChrOertlin left review comments

@islean islean islean approved these changes

@henrikstranneheim henrikstranneheim henrikstranneheim approved these changes

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating comments on the analysis fails
6 participants
@seallard @henrikstranneheim @ChrOertlin @diitaz93 @islean @clingen-sthlm