Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor endpoint for creating analysis #383

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Conversation

seallard
Copy link
Contributor

@seallard seallard commented Feb 2, 2024

Description

Refactor add-pending-analysis endpoint to follow the pattern of
request -> pydantic model -> service layer -> database layer -> database model -> service layer -> pydantic model -> response.

Fixed

  • Refactor endpoint for creating analyses
  • Add new integration test

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@seallard seallard marked this pull request as ready for review February 2, 2024 08:50
@seallard seallard requested a review from a team as a code owner February 2, 2024 08:50
@seallard seallard changed the title Refactor endpoints Refactor endpoint for creating analysis Feb 2, 2024
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 👍 !

trailblazer/dto/create_analysis_request.py Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seallard seallard merged commit 11a667b into master Feb 7, 2024
5 checks passed
@seallard seallard deleted the refactor-endpoints branch February 7, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants