Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for updating multiple analyses #397

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Add support for updating multiple analyses #397

merged 7 commits into from
Feb 20, 2024

Conversation

seallard
Copy link
Contributor

@seallard seallard commented Feb 19, 2024 •
edited
Loading

Description

Closes Clinical-Genomics/streamline-delivery#32.

Added

  • Endpoint for updating multiple analyses at once

This version is a

  • MINOR - when you add functionality in a backwards compatible manner

@seallard seallard marked this pull request as ready for review February 19, 2024 15:25
@seallard seallard requested a review from a team as a code owner February 19, 2024 15:25
@seallard seallard changed the title Add support for patching multiple analyses Add support for updating multiple analyses Feb 19, 2024
@clingen-sthlm clingen-sthlm temporarily deployed to stage February 20, 2024 10:12 Inactive
ChrOertlin
ChrOertlin approved these changes Feb 20, 2024
View reviewed changes
Copy link

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

trailblazer/server/api.py Show resolved Hide resolved
trailblazer/server/api.py Outdated Show resolved Hide resolved
trailblazer/services/utils.py Outdated Show resolved Hide resolved
islean
islean approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Current functionality uses the /analyses/analysis_id PUT right? So this does not need syncing?

trailblazer/server/api.py Show resolved Hide resolved
@clingen-sthlm clingen-sthlm temporarily deployed to stage February 20, 2024 14:39 Inactive
@seallard
Copy link
Contributor Author

Looks good! Current functionality uses the /analyses/analysis_id PUT right? So this does not need syncing?

Exactly, I left those endpoints alone for now

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seallard seallard merged commit de1ee99 into master Feb 20, 2024
4 checks passed
@seallard seallard deleted the add-patch-endpoint branch February 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrOertlin ChrOertlin ChrOertlin approved these changes

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add patch endpoint to trailblazer
4 participants
@seallard @ChrOertlin @islean @clingen-sthlm