Improve env var name #406
Merged
Improve env var name #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
islean
reviewed
Mar 11, 2024
| @@ -18,7 +18,7 @@ class Container(containers.DeclarativeContainer): | |||
| oauth_client_secret: str = os.environ.get("GOOGLE_CLIENT_SECRET") | |||
| oauth_redirect_uri: str = os.environ.get("GOOGLE_REDIRECT_URI") | |||
| google_oauth_base_url: str = os.environ.get("GOOGLE_OAUTH_BASE_URL") | |||
| encryption_key: str = os.environ.get("SECRET_KEY") | |||
| encryption_key: str = os.environ.get("ENCRYPTION_KEY") | |||
There was a problem hiding this comment.
I don't think I like "encryption_key". In many cryptographic schemas there are both public and private/secret keys. So I think this is probably a bit more unclear to me.
There was a problem hiding this comment.
Ah, what do you think it should be called?
There was a problem hiding this comment.
Either AES_SECRET_KEY or PRIVATE_KEY or something like it?
There was a problem hiding this comment.
maybe AES_PRIVATE_KEY might be best?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An env var was vaguely named.