Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change obsoleted qccollect key #67

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Conversation

patrikgrenfeldt
Copy link
Contributor

@patrikgrenfeldt patrikgrenfeldt commented Sep 18, 2019

This PR fixes the broken trailblazer scan for MIP 7.1

How to test:

  1. copy trailblazer database from prod to stage
  2. copy vocalgecko case from production to stage
  3. install master on stage of the hasta machine: bash servers/resources/hasta.scilifelab.se/update-trailblazer-stage.sh
  4. activate stage: us
  5. run following command: trailblazer scan | grep qccollect to show problem that this PR fixes
  6. install on stage of the hasta machine: bash servers/resources/hasta.scilifelab.se/update-trailblazer-stage.sh missing-qccollect
  7. run following command: trailblazer scan | grep qccollect

Expected outcome:
There should be no matches in the output for qccollect
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by @ingkebil
  • tests executed by @patrikgrenfeldt
  • "Merge and deploy" approved by @ingkebil
    Thanks for filling in who performed the code review and the test!

This is patch version bump because it patches a functionality in a backwards compatible manner

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.479% when pulling d5b3726 on missing-qccollect into a51e904 on master.

@patrikgrenfeldt
Copy link
Contributor Author

Test results:
Before fix: trailblazer scan | grep qccollect unexpected output, missing key: qccollect

After fix:
image

@patrikgrenfeldt patrikgrenfeldt merged commit 9d18186 into master Sep 18, 2019
@patrikgrenfeldt patrikgrenfeldt deleted the missing-qccollect branch September 18, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants