Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim off unnecessary requires and uses in testing files #121

Open
real-mj-song opened this issue Jul 14, 2016 · 1 comment
Open

trim off unnecessary requires and uses in testing files #121

real-mj-song opened this issue Jul 14, 2016 · 1 comment

Comments

@real-mj-song
Copy link

real-mj-song commented Jul 14, 2016

It seems like too many :refer :all are used for some testing files. In addition, I'm not so sure if all the imports are actually used. For instance, the below code imports errors.prettify_exception in two different places.

(ns exception_msgs.overwritten_fns.seq_ops
  (:use [errors.prettify_exception :only [line-number-format]])
  (:require [expectations :refer :all]
            [errors.messageobj :refer :all]
            [errors.testing_tools :refer :all]
            [errors.prettify_exception :refer :all]
            [utilities.file_IO :refer :all]
            ))
@elenam
Copy link

elenam commented Jul 14, 2016

I've been going through those. Many of them are needed, but not all.

On Thu, Jul 14, 2016 at 3:29 PM, Tony Song notifications@github.com wrote:

It seems like there are too many :refer :all are used for some testing
files. In addition, I'm not so sure if all the imports are used. For
instance, the below code imports errors.prettify_exception in two different
places.

(ns exception_msgs.overwritten_fns.seq_ops
(:use [errors.prettify_exception :only [line-number-format]])
(:require [expectations :refer :all]
[errors.messageobj :refer :all]
[errors.testing_tools :refer :all]
[errors.prettify_exception :refer :all]
[utilities.file_IO :refer :all]
))


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#121,
or mute the thread
https://github.com/notifications/unsubscribe/AAkU4QxNgWBx08OEjQX5FWAu-0Rlamnoks5qVpwogaJpZM4JM0Za
.

Dr. Elena Machkasova
Associate Professor of Computer Science
Division of Science and Mathematics
University of Minnesota, Morris
Office: Sci 2325
(320) 589-6308
http://cda.morris.umn.edu/~elenam/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants