Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some margin in header and paypall button #12

Merged
merged 5 commits into from Sep 28, 2016
Merged

Conversation

Malwine
Copy link
Member

@Malwine Malwine commented Sep 12, 2016

Fixes #11
and
fixes some spacing in the header
and
fixes #10

@Malwine Malwine changed the title Fix some marhin in header and paypall button Fix some margin in header and paypall button Sep 12, 2016
@davidchambers
Copy link
Contributor

This isn't looking quite right:

PayPal button

@Malwine
Copy link
Member Author

Malwine commented Sep 24, 2016

@davidchambers ups... what happened there... hm.... will have a look

@Malwine
Copy link
Member Author

Malwine commented Sep 27, 2016

@davidchambers when do you get that? I cant reproduce.

@Malwine
Copy link
Member Author

Malwine commented Sep 27, 2016

@davidchambers ah, in Chrome :O

@davidchambers
Copy link
Contributor

It's frustrating when things render differently in different browsers. 😠

This line seems to be the problem:

#paypal-button {
  float: right;
}

If I disable this rule the problem goes away. I can't explain this, but CSS is often inexplicable. 😝

@Malwine
Copy link
Member Author

Malwine commented Sep 27, 2016

Ah, interesting. How can we stick it to the right without float then?

@Malwine
Copy link
Member Author

Malwine commented Sep 27, 2016

@davidchambers Should be alright now. Could you check? 😊

@davidchambers
Copy link
Contributor

Could you check?

I'd like to, but I'm having trouble getting the site running.

$ bundle install
-bash: bundle: command not found

👎

$ gem install bundler
Fetching: bundler-1.13.1.gem (100%)
Successfully installed bundler-1.13.1
Parsing documentation for bundler-1.13.1
Installing ri documentation for bundler-1.13.1
Done installing documentation for bundler after 6 seconds
1 gem installed

👍

$ bundle install
...
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
...
An error occurred while installing nokogiri (1.6.8), and Bundler cannot continue.
Make sure that `gem install nokogiri -v '1.6.8'` succeeds before bundling.

👎

$ gem install nokogiri -v '1.6.8'
Building native extensions.  This could take a while...
...
To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /Users/dc/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/extensions/x86_64-darwin-15/2.3.0-static/nokogiri-1.6.8/mkmf.log

extconf failed, exit code 1

👎

Ruby, why must our relationship be this way? 😢

@davidchambers
Copy link
Contributor

With @Malwine's help I got the site running. I did three things:

  1. Launched Xcode and installed additional components when prompted.
  2. Ran bundle config build.nokogiri --use-system-libraries.
  3. Ran bundle install.

I'm not sure whether step 1 was necessary, but it certainly didn't hurt. :)


For the record I'm running OS X 10.11.6, MacPorts 2.3.4, and rbenv 0.3.0-362-g0c7224a.

@davidchambers
Copy link
Contributor

The fix you made is working for me, @Malwine. :)

I noticed one more thing: the border is missing. This change should fix it:

--- a/css/main.css
+++ b/css/main.css
@@ -150,7 +150,7 @@ img {
   border-radius: 6px;
   font-size: 13px;
   background: #fec348 none repeat scroll 0 0;
-  border-color: #feb215;
+  border: 1px solid #feb215;
   color: #002f86;
 }

@Malwine
Copy link
Member Author

Malwine commented Sep 28, 2016

Thanks @davidchambers you are the pro for github markdown formatting man 😅
I adjusted it now, can we merge then? ✨

@davidchambers
Copy link
Contributor

🌳

@davidchambers davidchambers merged commit 54345d4 into gh-pages Sep 28, 2016
@davidchambers davidchambers deleted the margin-fixes branch September 28, 2016 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants