Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to parse ConfigFile with multiple extruders #248

Closed
shermzm opened this issue Sep 8, 2023 · 9 comments
Closed

Unable to parse ConfigFile with multiple extruders #248

shermzm opened this issue Sep 8, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@shermzm
Copy link

shermzm commented Sep 8, 2023

Bug Report

Description

Since the latest update to

Steps to Reproduce

Add a new printer
Test connection, succeed
Click finish
Error appears

Expected Behavior

Click finish, view dashboard.

Version Information

  • Mobileraker: 2.6
  • Klipper: v0.11.0-271-g5f990f93
  • Moonraker: v0.8.0-138-gfe120952

Debug Logs

mobileraker_2023-09-07T20-30-28.log

Exception:
type 'Null' is not a subtype of type 'num' in type cast

#0 _$$_ConfigExtruderFromJson (package:common/data/dto/config/config_extruder.g.dart:12)
#1 new _$_ConfigExtruder.fromJson (package:common/data/dto/config/config_extruder.freezed.dart:205)
#2 _$ConfigExtruderFromJson (package:common/data/dto/config/config_extruder.freezed.dart:18)
#3 new ConfigExtruder.fromJson (package:common/data/dto/config/config_extruder.dart:26)
#4 new ConfigFile.parse (package:common/data/dto/config/config_file.dart:71)
#5 PrinterService._updateConfigFile (package:common/service/moonraker/printer_service.dart:703)
#6 PrinterService._parseObjectType (package:common/service/moonraker/printer_service.dart:533)
#7 PrinterService._temperatureStore. (package:common/service/moonraker/printer_service.dart:482)
#8 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625)
#9 PrinterService._parseQueriedObjects (package:common/service/moonraker/printer_service.dart:620)
#10 PrinterService._printerObjectsQuery (package:common/service/moonraker/printer_service.dart:779)

#11 PrinterService.refreshPrinter (package:common/service/moonraker/printer_service.dart:207)

@shermzm shermzm added the bug Something isn't working label Sep 8, 2023
@Clon1998
Copy link
Owner

Clon1998 commented Sep 8, 2023

Hey,
thanks for reporting.
Could you please share the output of the following website if you visit it on your PC/Browser:

http:///printer/objects/query?configfile

@shermzm
Copy link
Author

shermzm commented Sep 8, 2023

Sure thing, here you go @Clon1998

query.json.txt

@Clon1998
Copy link
Owner

Clon1998 commented Sep 8, 2023

Thanks,
seems like I did a small ooopsie while rewriting that logic.
I fixed it, and will trigger a new build. However, since I am sure I mixed up even more and this is not as critical I wont immediately release a hotfix. In the meantime, you can join the testflight group since the fix will be available there in about 1hr.
You can join to test group here: https://testflight.apple.com/join/h9JwuyR0

@shermzm
Copy link
Author

shermzm commented Sep 8, 2023

Thanks for your quick resolution! I'm on Android, so I'll just wait for the next version to be released.

@Clon1998
Copy link
Owner

Clon1998 commented Sep 8, 2023

Wait...
I thought you are on IOS.
Android is even easier. I will upload the APK to the 2.6.2 Tag that includes the fix

@shermzm
Copy link
Author

shermzm commented Sep 8, 2023

Even better, thank you!

@Clon1998
Copy link
Owner

Clon1998 commented Sep 8, 2023

See 2.6.0 tag

@shermzm
Copy link
Author

shermzm commented Sep 8, 2023

That one works again. Thank you!

@Clon1998
Copy link
Owner

Included in 2.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants