Add some nullable annotations to make API slightly nicer to work with

ClosedXML · Apr 25, 2024 · f99e96a · f99e96a
1 parent 2f8cd1e
commit f99e96a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/ClosedXML/Excel/IXLWorksheets.cs b/ClosedXML/Excel/IXLWorksheets.cs
@@ -1,8 +1,7 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Data;
+using System.Diagnostics.CodeAnalysis;
 
 namespace ClosedXML.Excel
 {
@@ -32,7 +31,7 @@ public interface IXLWorksheets : IEnumerable<IXLWorksheet>
 
         void Delete(Int32 position);
 
-        bool TryGetWorksheet(string sheetName, out IXLWorksheet worksheet);
+        bool TryGetWorksheet(string sheetName, [NotNullWhen(true)] out IXLWorksheet? worksheet);
 
         IXLWorksheet Worksheet(String sheetName);
 

diff --git a/ClosedXML/Excel/XLWorksheets.cs b/ClosedXML/Excel/XLWorksheets.cs
@@ -3,6 +3,7 @@
 using System.Collections.Generic;
 using System.Data;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace ClosedXML.Excel
@@ -50,7 +51,7 @@ public Boolean Contains(String sheetName)
             return _worksheets.ContainsKey(sheetName);
         }
 
-        bool IXLWorksheets.TryGetWorksheet(string sheetName, out IXLWorksheet? worksheet)
+        bool IXLWorksheets.TryGetWorksheet(string sheetName, [NotNullWhen(true)] out IXLWorksheet? worksheet)
         {
             if (TryGetWorksheet(sheetName, out var foundSheet))
             {
@@ -62,7 +63,7 @@ bool IXLWorksheets.TryGetWorksheet(string sheetName, out IXLWorksheet? worksheet
             return false;
         }
 
-        internal bool TryGetWorksheet(string sheetName, out XLWorksheet? worksheet)
+        internal bool TryGetWorksheet(string sheetName, [NotNullWhen(true)] out XLWorksheet? worksheet)
         {
             if (_worksheets.TryGetValue(sheetName.UnescapeSheetName(), out worksheet))
             {