Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'in' and 'ref' for value types where applicable #787

Open
1 of 3 tasks
Pankraty opened this issue Apr 18, 2018 · 2 comments
Open
1 of 3 tasks

Use 'in' and 'ref' for value types where applicable #787

Pankraty opened this issue Apr 18, 2018 · 2 comments

Comments

@Pankraty
Copy link
Member

Do you want to request a feature or report a bug?

  • Bug
  • Feature
  • Enhancement

Version of ClosedXML

e.g. 0.93

What is the current behavior?

With a new approach to styles and addresses processing structs became widely used in ClosedXML.

C# 7.2 introduces new features regarding value types (https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-7-2#reference-semantics-with-value-types) so we can have some use of them after CloseXML is upgraded to C# 7.2. Specifically, marking input parameters with in keyword looks promising for me - on the synthetic benchmark I achieved about 34% of performance improvement with this.

For now, we can park this issue.

@igitur
Copy link
Member

igitur commented Apr 18, 2018 via email

@Pankraty
Copy link
Member Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants