Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with opening files from LibreOffice test suite #808

Open
Pankraty opened this issue Apr 24, 2018 · 2 comments
Open

Fix issues with opening files from LibreOffice test suite #808

Pankraty opened this issue Apr 24, 2018 · 2 comments
Assignees

Comments

@Pankraty
Copy link
Member

Continuation of #806.

Quote:

Not urgent, but at some stage, we should investigate one by one why these files don't load in ClosedXML. I see we have to do some work on pivot tables. That doesn't surprise me. Maybe you can look at the first file, formats.xlsx, since you've been doing a lot of work on it.

@Pankraty Pankraty self-assigned this Apr 24, 2018
@Pankraty
Copy link
Member Author

From the collection of files that fail to load in ClosedXML

  1. 11 files relate to pivot tables and I don't feel brave enough to cope with them
  2. 2 files are invalid (formats.xlsx and tdf100709.xlsx). ClosedXML is not designed to manage corrupted files so I suggest removing them.
  3. 2 files have comments of non-rectangular shape (universal-content-strict.xlsx and universal-content.xlsx) and wait for XLWorkbook.GetCommentShape returns null and LoadSpreadsheetDocument throws NullReferenceException when comment shape is not rectangle #645.
  4. xf_default_values.xlsx has pictures with the duplicate ids. Apparently, duplicate IDs are allowed in XLSX so I removed the validation that threw exceptions on attempts to assign the existing ID to the picture.

@igitur
Copy link
Member

igitur commented Apr 27, 2018

I feel that pivot tables should be refactored. The current code is quite messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants