Use types values in a cell. #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahav
force-pushed
the
1894-data-types
branch
from
87aadfb
to
4e4ce7c
Compare
…ype of IXLCell.Value from Object to XLCellValue. This provides a better semantic, so users know exactly what values are allowed in a cell and replaces "guessing" of string values for some edge cases. The new cell value type is XLCellValue (public readonly struct to avoid boxing/unboxing). Adjust API where necessary (see migration doc). Key benefits: * The value is now typed and it is far easier to do operations on it (e.g. sorting, comparison....) * Streamline the behavior and decrease amount of unexpected results. * Value is no longer guessed Due to inconsistencies in writing, we no longer write type to the files, if it is a number (=default). Key benefit is fewer allocations (a big problem for ClosedXML). Other than that, only two files were modified: * Sorting.xslx test file was incorrect - the Mixed sheet has a number 9 in the incorrect place (should be just before dates, but was after). * CellValues.xlsx test file was updated to reflect change of logical-to-text conversion (was True, now TRUE) and TimeSpan-to-text conversion (originally wrote days separately, now days are merged into hours as 24 hours)
jahav
force-pushed
the
1894-data-types
branch
from
e4be087
to
b787947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR so I can work easily review and start to clean up and improve my dev branch (which is an incomplete mess).
Test files:
<c r="A1" t ="s"/>without a value) - that value is a blank, specifying type without value doesn't do anything and I represent a missing value is a blank type anyway.t="n"is redundant).Will resolve #1894 when done and merged.