Fixes issue #1917 not contains filter #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er reapplying filters (ClosedXML#1917).
…n just pass a value and get info, if the value satisfies the filter or not. Having two different semantic for condition makes it hard to reason about the code.
jahav
force-pushed
the
1917-not-contains-filter
branch
from
344607e
to
b7986be
Compare
|
Resolves #1917 |
|
@cjundt I didn't like how the condition has sometimes had to be inverted, so I changed to code so it always returns true when value satisfies the filter. Be warned that autofilter is going to be revamped, likely in 0.101, I already researched how it actually work and done some work, but it just didn't make it. You have seen it, conditions are duplicated across load code, XLFilteredColumn and XLCustomFilteredColumn, filters don't work correctly (no wildcard support, no correct coercion for comparison filters, equals operator applying filter on filter value, while not equal uses normal textual value and the rest). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests and code fix in order to handle the "Not" string filters family as expected.