Store rich text as an immutable rich text #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l be stored in shared string table and thus belongs to sst.
…bleRichText. The XLRichText transparently updates immutable rich text, whenever it changes (run, pohonetic runs or phonetic properties). This is required for shared string table, because items stored in a reverse dictionary must be immutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step 3 of shared string table (followup of #2115).
It introduces a new type (internal for now)
XLImmutableRichTextand the new type is now used to store rich text in a value slice (rich text was moved from misc slice). The immutable rich text in a cell is updated when the mutable rich text is changed.The immutable rich text is necessary for a reverse dictionary of shared string table. Mutable types are highly unsuitable for dictionary due hashcode.
I am not very happy with API of
XLRichText(for the second time) and will likely replace it with the immutable type, but not now.