Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#153 fixed filtering for AWS commands #155

Merged
merged 1 commit into from
Oct 12, 2020
Merged

#153 fixed filtering for AWS commands #155

merged 1 commit into from
Oct 12, 2020

Conversation

meshuga
Copy link
Member

@meshuga meshuga commented Oct 11, 2020

closes #153

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #155 into develop will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #155   +/-   ##
========================================
  Coverage    19.30%   19.30%           
========================================
  Files           45       45           
  Lines         2989     2989           
========================================
  Hits           577      577           
  Misses        2412     2412           
Impacted Files Coverage Δ
cloudiscovery/provider/all/command.py 52.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4667aaf...5784d29. Read the comment docs.

Copy link
Member

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@meshuga meshuga merged commit c77fb8b into develop Oct 12, 2020
@leandrodamascena leandrodamascena deleted the fix_filters branch November 12, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering does not seem to work
2 participants