Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify demo link to support all demos #82

Merged
merged 1 commit into from Jul 30, 2018
Merged

Modify demo link to support all demos #82

merged 1 commit into from Jul 30, 2018

Conversation

RishabhJain2018
Copy link
Member

@RishabhJain2018 RishabhJain2018 commented Jul 30, 2018

@deshraj @uttu357 Please review the PR.

I have modified the Demo link on the home page in order to work with all the demos we are having since all the demos aren't hosted on CloudCV. So, now all the demos will open in a new tab rather than opening in a iframe under Projects sections of cloudcv website.

@gupta-utkarsh gupta-utkarsh merged commit 39dff86 into develop Jul 30, 2018
gupta-utkarsh added a commit that referenced this pull request Jul 30, 2018
* feat(demo-views): Demos now have different views on home and project page (#80)

feat(demo-views): Demos now have different views on home and project

* Modify demo link to support all demos (#82)
@RishabhJain2018 RishabhJain2018 deleted the fix1 branch July 30, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants