Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Added basic setup for Angular #1

Merged
merged 4 commits into from Jan 23, 2018
Merged

Conversation

aka-jain
Copy link
Member

@aka-jain aka-jain commented Jan 21, 2018

@deshraj Added basic setup for EvalAI frontend.
cc @spyshiv @RishabhJain2018

@aka-jain aka-jain requested a review from spyshiv January 21, 2018 18:53
@spyshiv
Copy link
Member

spyshiv commented Jan 22, 2018

@aka-jain We should setup project in root directory. Creating evalai folder inside root directory will cause additional step (i.e. cd evalai) in development

@aka-jain
Copy link
Member Author

Angular made this directory but it's own. Basically ng new app generate a new dir and setup all the files in it.

But we can check how to overcome this problem.

@spyshiv
Copy link
Member

spyshiv commented Jan 22, 2018

@aka-jain : Yes. we can overcome this. Check this out.
https://github.com/angular/angular-cli/wiki/new#options
I'm on it.

@spyshiv
Copy link
Member

spyshiv commented Jan 22, 2018

@aka-jain : I have updated the basic setup. Everything is working fine including unit test and e2e test. Please check changes once so that I can merge this PR.
PS: I am using angular-cli 1.6.5

@@ -0,0 +1,3 @@
h1 {
text-align: center;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line

@spyshiv
Copy link
Member

spyshiv commented Jan 23, 2018

Merging this PR

@spyshiv spyshiv merged commit 25612d6 into master Jan 23, 2018
@spyshiv spyshiv deleted the feature/angular-initial-setup branch February 3, 2018 00:50
Kajol-Kumari pushed a commit to Kajol-Kumari/EvalAI-ngx that referenced this pull request Feb 15, 2020
…512b1ded78b969416f28

Fix for 2 vulnerabilities
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants