This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For terms and conditions modal, created a new component as a child of challengeparticipate component
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 52.65% 52.19% -0.47%
==========================================
Files 59 60 +1
Lines 3069 3148 +79
Branches 354 367 +13
==========================================
+ Hits 1616 1643 +27
- Misses 1370 1421 +51
- Partials 83 84 +1
Continue to review full report at Codecov.
|
@RishabhJain2018 @lunayach @galipremsagar @Shekharrajak Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some first pass of comments.
src/app/components/challenge/challengeparticipate/challengeparticipate.component.html
Show resolved
Hide resolved
galipremsagar
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than issue which will be handled in a separate PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
For terms and conditions modal, created a new component as a child of challengeparticipate component
Link to live demo: http://pr-153-evalai.surge.sh
Screenshot 1:
Screenshot 2:
Screenshot 3:
Screenshot 4:
Screenshot 5: