Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Modify the challenge participant page #153

Merged
merged 10 commits into from
Jul 20, 2019

Conversation

Sanji515
Copy link
Member

@Sanji515 Sanji515 commented Jun 20, 2019

Changes proposed in this pull request:

  • For terms and conditions modal, created a new component as a child of challengeparticipate component

  • Link to live demo: http://pr-153-evalai.surge.sh

Screenshot 1:

Screenshot from 2019-06-20 23-32-43

Screenshot 2:

Screenshot from 2019-06-20 23-31-26

Screenshot 3:

Screenshot from 2019-06-20 23-32-01

Screenshot 4:

Screenshot from 2019-06-20 23-32-11

Screenshot 5:

Screenshot from 2019-06-20 23-32-16

- For terms and conditions modal, created a new component as a child of challengeparticipate component
@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #153 into master will decrease coverage by 0.46%.
The diff coverage is 33.75%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   52.65%   52.19%   -0.47%     
==========================================
  Files          59       60       +1     
  Lines        3069     3148      +79     
  Branches      354      367      +13     
==========================================
+ Hits         1616     1643      +27     
- Misses       1370     1421      +51     
- Partials       83       84       +1
Impacted Files Coverage Δ
...ponents/publiclists/teamlist/teamlist.component.ts 32.25% <14.28%> (-2.97%) ⬇️
src/app/app.component.ts 35.82% <33.33%> (-0.12%) ⬇️
src/app/services/global.service.ts 39.03% <42.85%> (+0.25%) ⬆️
...ions-modal/terms-and-conditions-modal.component.ts 45.71% <45.71%> (ø)
Impacted Files Coverage Δ
...ponents/publiclists/teamlist/teamlist.component.ts 32.25% <14.28%> (-2.97%) ⬇️
src/app/app.component.ts 35.82% <33.33%> (-0.12%) ⬇️
src/app/services/global.service.ts 39.03% <42.85%> (+0.25%) ⬆️
...ions-modal/terms-and-conditions-modal.component.ts 45.71% <45.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3021ce0...2dd6160. Read the comment docs.

@Sanji515
Copy link
Member Author

@galipremsagar galipremsagar self-requested a review July 17, 2019 04:05
Copy link
Collaborator

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some first pass of comments.

Copy link
Collaborator

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than issue which will be handled in a separate PR.

@RishabhJain2018 RishabhJain2018 merged commit 4d60082 into Cloud-CV:master Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants