-
Notifications
You must be signed in to change notification settings - Fork 61
Modify the user profile to the current theme of EvalAI #162
Conversation
Modified the user profile page For change and update profile instead of redirecting to new page, editing inside modal
@RishabhJain2018 @galipremsagar @lunayach @Shekharrajak I'm updating the user profile details and change password inside the modal which I think is better than redirecting to new page and then updating the things, please have a look and give your reviews. |
{{user.first_name}} | ||
<div class="user-details"> | ||
<div class="item"> | ||
<span class="text-light-black fw-semibold fs-12"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Profile page design can be improved.
@Sanji515 Please resolve the conflicts here. |
@RishabhJain2018 done |
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 53.15% 53.04% -0.12%
==========================================
Files 59 59
Lines 3014 3041 +27
Branches 337 346 +9
==========================================
+ Hits 1602 1613 +11
- Misses 1329 1345 +16
Partials 83 83
Continue to review full report at Codecov.
|
…tags in profile html file
…into profile-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side. Was working fine.
@Sanji515 but you could resolve some @Shekharrajak's comments.
@RishabhJain2018 @Shekharrajak I made the changes, Please have a look. |
Changes proposed in this pull request:
Modified the user profile page to the current theme of EvalAI
For
change password
andupdate profile
instead of redirecting to new page, editing inside the modalLink to live demo: http://pr-162-evalai.surge.sh
Screenshot 1:
Screenshot 2:
Screenshot 3:
Screenshot 4: