Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Modify the user profile to the current theme of EvalAI #162

Merged
merged 9 commits into from
Jul 19, 2019

Conversation

Sanji515
Copy link
Member

@Sanji515 Sanji515 commented Jul 4, 2019

Changes proposed in this pull request:

  • Modified the user profile page to the current theme of EvalAI

  • For change password and update profile instead of redirecting to new page, editing inside the modal

  • Link to live demo: http://pr-162-evalai.surge.sh

Screenshot 1:

Screenshot from 2019-07-05 01-14-28

Screenshot 2:

Screenshot from 2019-07-05 01-14-38

Screenshot 3:

Screenshot from 2019-07-05 01-14-51

Screenshot 4:

Screenshot from 2019-07-05 01-14-59

Modified the user profile page
For change and update profile instead of redirecting to new page, editing inside modal
@Sanji515
Copy link
Member Author

Sanji515 commented Jul 4, 2019

@RishabhJain2018 @galipremsagar @lunayach @Shekharrajak

I'm updating the user profile details and change password inside the modal which I think is better than redirecting to new page and then updating the things, please have a look and give your reviews.

src/app/components/utility/input/input.component.ts Outdated Show resolved Hide resolved
src/app/components/utility/modal/modal.component.ts Outdated Show resolved Hide resolved
{{user.first_name}}
<div class="user-details">
<div class="item">
<span class="text-light-black fw-semibold fs-12">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profile page design can be improved.

@RishabhJain2018
Copy link
Member

@Sanji515 Please resolve the conflicts here.

@Sanji515
Copy link
Member Author

Please resolve the conflicts here.

@RishabhJain2018 done

@codecov-io
Copy link

codecov-io commented Jul 19, 2019

Codecov Report

Merging #162 into master will decrease coverage by 0.11%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   53.15%   53.04%   -0.12%     
==========================================
  Files          59       59              
  Lines        3014     3041      +27     
  Branches      337      346       +9     
==========================================
+ Hits         1602     1613      +11     
- Misses       1329     1345      +16     
  Partials       83       83
Impacted Files Coverage Δ
src/app/components/profile/profile.component.ts 51.25% <ø> (ø) ⬆️
...rc/app/components/utility/modal/modal.component.ts 34.9% <27.27%> (+0.38%) ⬆️
...rc/app/components/utility/input/input.component.ts 58.76% <55.55%> (+0.06%) ⬆️
Impacted Files Coverage Δ
src/app/components/profile/profile.component.ts 51.25% <ø> (ø) ⬆️
...rc/app/components/utility/modal/modal.component.ts 34.9% <27.27%> (+0.38%) ⬆️
...rc/app/components/utility/input/input.component.ts 58.76% <55.55%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a4498...c194d7f. Read the comment docs.

Copy link
Member

@lunayach lunayach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side. Was working fine.
@Sanji515 but you could resolve some @Shekharrajak's comments.

@Sanji515
Copy link
Member Author

@RishabhJain2018 @Shekharrajak I made the changes, Please have a look.

@RishabhJain2018 RishabhJain2018 merged commit 9fc74cc into Cloud-CV:master Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants