Skip to content

Commit

Permalink
Frontend_V2: Fix the JS error when loading all challenges on the chal…
Browse files Browse the repository at this point in the history
…lenge page (#3449)

* remove js errors on challenge list apge

* fix js error

* fix windowscroll error

* add page scroll event

Co-authored-by: Rishabh Jain <rishabhjain2018@gmail.com>
  • Loading branch information
gautamjajoo and RishabhJain2018 committed Jun 15, 2021
1 parent 4e4568e commit 21ea94c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div *ngIf="routerPublic.url === allChallengesRoutePathCommon" [@.disabled]="true">
<h4 class="fw-light">All challenges</h4>
<mat-tab-group>
<mat-tab label="Ongoing ({{ ongoingChallenges.length }})">
<mat-tab label="Ongoing ({{ ongoingChallenges.length }})" id="ongoing-challenges">
<div *ngIf="ongoingChallenges.length === 0" class="none fw-light fs-16">No challenges found.</div>
<div class="row pd-lr-20">
<div class="col s12 m4 l3" *ngFor="let challenge of ongoingChallenges">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class ChallengelistComponent implements OnInit {
/**
* Ongoing challenges list
*/
ongoingChallenges: any;
ongoingChallenges = [];

/**
* Past challeges list
Expand Down Expand Up @@ -90,7 +90,7 @@ export class ChallengelistComponent implements OnInit {
/**
* List of filtered ongoing challenges
*/
filteredOngoingChallenges: any;
filteredOngoingChallenges = [];

/**
* List of filtered upcoming challenges
Expand Down

0 comments on commit 21ea94c

Please sign in to comment.