Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for starring and unstarring a challenge. #1203

Merged
merged 3 commits into from Aug 24, 2017
Merged

Add UI for starring and unstarring a challenge. #1203

merged 3 commits into from Aug 24, 2017

Conversation

RishabhJain2018
Copy link
Member

fixes #1202 . @deshraj @aka-jain Please review the PR.
star-demo

@deshraj
Copy link
Member

deshraj commented Aug 24, 2017

Please add a star icon on the left side of the button.

parameters.callback = {
onSuccess: function(response) {
var details = response.data;
console.log(details);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

@deshraj
Copy link
Member

deshraj commented Aug 24, 2017

Can you please paste a screenshot again?

@RishabhJain2018
Copy link
Member Author

@deshraj Please take a look!
shot1
shot2

@deshraj deshraj merged commit af86326 into master Aug 24, 2017
@deshraj deshraj deleted the star-ui branch August 24, 2017 19:31
deshraj pushed a commit that referenced this pull request Oct 24, 2018
* Add UI for starring and unstarring a challenge.

* Fix review changes

* Fix review changes
HargovindArora pushed a commit to HargovindArora/EvalAI that referenced this pull request Nov 17, 2018
…1203)

* Add UI for starring and unstarring a challenge.

* Fix review changes

* Fix review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI for starring and unstarring a challenge.
2 participants