Setup ModelAdmin class for each model in Host and Challenge app #133
Conversation
gauthamzz
changed the title
|
That's not right , What else can be the problem |
|
@gauthamzz Check the logs of the travis-ci failure. |
|
#138 is also solved |
|
@gauthamzz Can you open a new PR for #138? |
|
@gauthamzz : can you open a new Pr for this? |
| # Register your models here. | ||
|
|
||
| from .models import Challenge, Phase | ||
| from base.admin import TimeStampedAdmin |
There was a problem hiding this comment.
add a new line here in between imports. logically group import statements.
Also base.admin should be before .models import
|
|
||
| @admin.register(Challenge) | ||
| class ChallengeModelAdmin(TimeStampedAdmin): | ||
| list_display = ("title", |
There was a problem hiding this comment.
this should be in a line. we have limit for 120 characters. also not all the attributes are required. I will prefer title, start_date, end_date, creator, published, enable_forum, anonymous_leaderboard
| "published", | ||
| "enable_forum", | ||
| "anonymous_leaderboard") | ||
| list_filter = ("title", |
There was a problem hiding this comment.
list_filter is generally for a thing where some foreign key is there or some field having limited set of values. title, description, terms_and_condition, submission_guidelines, evaluation_details, image will be generally unique for each challenge.
Ideal candidates here are creator, published,enable_forum,anonymous_leaderboard
| "published", | ||
| "enable_forum", | ||
| "anonymous_leaderboard") | ||
| search_fields = ("title", |
There was a problem hiding this comment.
search on title and creator will do as of now.
| @@ -1,3 +1,19 @@ | |||
| from django.contrib import admin | |||
|
|
|||
| # Register your models here. | |||
There was a problem hiding this comment.
ill delete this PR and make two separate ones
| @admin.register(Phase) | ||
| class PhaseModelAdmin(TimeStampedAdmin): | ||
| list_display = ("name", "description", "leaderboard_public", "challenge") | ||
| list_filter = ("name", "description", "leaderboard_public", "challenge") |
There was a problem hiding this comment.
leaderboard_public and challenge makes sense here
|
|
||
| @admin.register(Phase) | ||
| class PhaseModelAdmin(TimeStampedAdmin): | ||
| list_display = ("name", "description", "leaderboard_public", "challenge") |
There was a problem hiding this comment.
remove description. reason : it is a text field hence width of row will be larger and a slight inconvenience when looking at the dataset.
| class PhaseModelAdmin(TimeStampedAdmin): | ||
| list_display = ("name", "description", "leaderboard_public", "challenge") | ||
| list_filter = ("name", "description", "leaderboard_public", "challenge") | ||
| search_fields = ("name", "description", "leaderboard_public", "challenge") |
* Fix#1338 Navigation menu now appears for mobile users * add scss changes in landing.scss * add scss changes in landing.scss iteration 2 * Fix Cloud-CV#1338 add the missing fields in the navigation of Home page * Fix Cloud-CV#1338 add the missing fields in the navigation of Home page
* modified contact us page * minor change * minor responsive change
No description provided.