Update feature to send emails to evalai users using amazon ses #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RishabhJain2018
force-pushed
the
bulk-email
branch
from
8248333
to
6b3fb79
Compare
deshraj
requested changes
Apr 4, 2018
apps/web/views.py
Outdated
| 'notification_email_conformation.html', | ||
| {'message': 'All the emails are sent successfully!'}) | ||
| except: | ||
| return render(request, |
There was a problem hiding this comment.
Whenever there is an exception, try to log it with proper severity level.
apps/web/views.py
Outdated
| else: | ||
| return render(request, 'error404.html') | ||
| else: | ||
| return render(request, 'error404.html') | ||
| return render(request, 'error_superuser.html') |
There was a problem hiding this comment.
Just return 404. No need to show exactly what happened.
apps/web/views.py
Outdated
| template_name = 'notification_email.html' | ||
| emails = User.objects.all().exclude(email__isnull=True, email__exact='').values_list('email', flat=True) | ||
| htmly = get_template('notification_email.html') | ||
| users = list(User.objects.exclude(email__exact='').values_list('email', flat=True)) |
There was a problem hiding this comment.
Do we really need to convert to list? Doesn't values_list takes care of that? I am not sure about this though. Please add a comment on the line why we are converting to list if we need to do this.
There was a problem hiding this comment.
No, for now we don't need that. Earlier boto required it to be converted to a list rather than Queryset object. :-)
deshraj
approved these changes
Apr 4, 2018
deshraj
pushed a commit
that referenced
this pull request
Oct 24, 2018
HargovindArora
pushed a commit
to HargovindArora/EvalAI
that referenced
this pull request
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deshraj Please review the PR.
Fixes #1549