Fix #1995: Feature for Baseline Entries #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue#1995 Frontend badge
Issue#1995 payload bug
krtkvrm
changed the title
Modified Tests for Baseline Submissions
|
@deshraj @RishabhJain2018 Please review! |
krtkvrm
changed the title
krtkvrm
changed the title
RishabhJain2018
requested changes
Apr 4, 2019
|
@vkartik97 Let's merge this by tomorrow. Please make the changes. It's a really nice feature. :) |
krtkvrm
changed the title
krtkvrm
changed the title
There was a problem hiding this comment.
@vkartik97 I'm merging this for now since we need it urgently. Please add tests for this before working on any other feature.
| @@ -280,6 +280,9 @@ def change_submission_data_and_visibility( | |||
| "error": "Sorry, cannot accept submissions since challenge phase is not public" | |||
| } | |||
| return Response(response_data, status=status.HTTP_403_FORBIDDEN) | |||
| elif request.data.get("is_baseline"): | |||
There was a problem hiding this comment.
@vkartik97 Can you please add tests for this condition.
| for data in sorted_leaderboard_data: | ||
| if data["submission__participant_team__team_name"] in team_list: | ||
| continue | ||
| elif data['submission__is_baseline'] is True: |
There was a problem hiding this comment.
Please add tests for this condition.
RishabhJain2018
approved these changes
Apr 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1995
Deliverables:
baseline_submissionchange_submission_data_and_visibilityto change to toggle the value of the fieldbaseline, only for hosts.My submissionstable for challenge hosts only, so that they can toggle this functionality.baselineto show which entries are baseline.Screenshots: