Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage reports on front-end unit tests #2335

Merged
merged 12 commits into from
Jul 23, 2019

Conversation

Sanji515
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2ffc8e8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2335   +/-   ##
=========================================
  Coverage          ?   58.83%           
=========================================
  Files             ?       77           
  Lines             ?     4715           
  Branches          ?        0           
=========================================
  Hits              ?     2774           
  Misses            ?     1941           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffc8e8...e6354f4. Read the comment docs.

@Sanji515
Copy link
Member Author

@galipremsagar @RishabhJain2018 Please review

@galipremsagar
Copy link
Collaborator

@Sanji515 , It says we have no coverage report?? I think we need to fix that aswell?

@Sanji515
Copy link
Member Author

@Sanji515 , It says we have no coverage report?? I think we need to fix that aswell?

It's saying because it don't have any previous data to match with in master branch, so when it will be merged then it will show diff coverage report for all other PR's

@galipremsagar
Copy link
Collaborator

@Sanji515 , It says we have no coverage report?? I think we need to fix that aswell?

It's saying because it don't have any previous data to match with in master branch, so when it will be merged then it will show diff coverage report for all other PR's

Cool 👍

@galipremsagar
Copy link
Collaborator

@Sanji515, can you update your branch so that we can merge it. This looks good to me.

@galipremsagar
Copy link
Collaborator

looks good. Please merge this @RishabhJain2018

@RishabhJain2018 RishabhJain2018 merged commit 4682375 into Cloud-CV:master Jul 23, 2019
@RishabhJain2018 RishabhJain2018 deleted the coverage-reports branch July 23, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants